Re: [PATCH] WIP: dt-bindings: arm: firmware: tlm,trusted-foundations: Convert txt bindings to yaml

[David Heidelberg <david@xxxxxxx>]

On Tue, Oct 19 2021 at 16:38:18 -0500, Rob Herring <robh@xxxxxxxxxx> 
wrote:
> On Sat, Oct 09, 2021 at 12:45:18PM +0200, David Heidelberg wrote:
> >  Convert Trusted Foundation binding to the YAML syntax.
>
> Looks fine. Why WIP?

Can you drop the WIP prefix I forgot or should I resend?


> If version number ranges are known, you could add constraints on 
> those.

from driver:
        * we are not using version information for now since currently
        * supported SMCs are compatible with all TF releases
so I guess at least driver currently doesn't care and know any enums.

David

> >  Signed-off-by: David Heidelberg <david@xxxxxxx>
> >  ---
> >   .../arm/firmware/tlm,trusted-foundations.txt  | 20 --------
> >   .../arm/firmware/tlm,trusted-foundations.yaml | 46 
> > +++++++++++++++++++
> >   2 files changed, 46 insertions(+), 20 deletions(-)
> >   delete mode 100644 
> > Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
> >   create mode 100644 
> > Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml
> >
> >  diff --git 
> > a/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt 
> > b/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
> >  deleted file mode 100644
> >  index 780d0392a66b..000000000000
> >  --- 
> > a/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
> >  +++ /dev/null
> >  @@ -1,20 +0,0 @@
> >  -Trusted Foundations
> >  --------------------
> >  -
> >  -Boards that use the Trusted Foundations secure monitor can signal 
> > its
> >  -presence by declaring a node compatible with 
> > "tlm,trusted-foundations"
> >  -under the /firmware/ node
> >  -
> >  -Required properties:
> >  -- compatible: "tlm,trusted-foundations"
> >  -- tlm,version-major: major version number of Trusted Foundations 
> > firmware
> >  -- tlm,version-minor: minor version number of Trusted Foundations 
> > firmware
> >  -
> >  -Example:
> >  -	firmware {
> >  -		trusted-foundations {
> >  -			compatible = "tlm,trusted-foundations";
> >  -			tlm,version-major = <2>;
> >  -			tlm,version-minor = <8>;
> >  -		};
> >  -	};
> >  diff --git 
> > a/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml 
> > b/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml
> >  new file mode 100644
> >  index 000000000000..9d1857c0aa07
> >  --- /dev/null
> >  +++ 
> > b/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml
> >  @@ -0,0 +1,46 @@
> >  +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >  +%YAML 1.2
> >  +---
> >  +$id: 
> > "http://devicetree.org/schemas/arm/firmware/tlm,trusted-foundations.yaml#";
> >  +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> >  +
> >  +title: Trusted Foundations
> >  +
> >  +description: |
> >  +  Boards that use the Trusted Foundations secure monitor can 
> > signal its
> >  +  presence by declaring a node compatible under the /firmware/ node
> >  +
> >  +maintainers:
> >  +  - Stephen Warren <swarren@xxxxxxxxxx>
> >  +
> >  +properties:
> >  +  $nodename:
> >  +    const: trusted-foundations
> >  +
> >  +  compatible:
> >  +    const: tlm,trusted-foundations
> >  +
> >  +  tlm,version-major:
> >  +    $ref: /schemas/types.yaml#/definitions/uint32
> >  +    description: major version number of Trusted Foundations 
> > firmware
> >  +
> >  +  tlm,version-minor:
> >  +    $ref: /schemas/types.yaml#/definitions/uint32
> >  +    description: minor version number of Trusted Foundations 
> > firmware
> >  +
> >  +required:
> >  +  - compatible
> >  +  - tlm,version-major
> >  +  - tlm,version-minor
> >  +
> >  +additionalProperties: false
> >  +
> >  +examples:
> >  +  - |
> >  +    firmware {
> >  +      trusted-foundations {
> >  +        compatible = "tlm,trusted-foundations";
> >  +        tlm,version-major = <2>;
> >  +        tlm,version-minor = <8>;
> >  +      };
> >  +    };
> >  --
> >  2.33.0