Re: [PATCH 3/3] dt-bindings: net: ti,bluetooth: Convert to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

On Tue, Oct 19, 2021 at 5:41 PM David Lechner <david@xxxxxxxxxxxxxx> wrote:
> On 10/19/21 7:43 AM, Geert Uytterhoeven wrote:
> > Convert the Texas Instruments serial-attached bluetooth Device Tree
> > binding documentation to json-schema.
> >
> > Add missing max-speed property.
> > Update the example.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> > I listed David as maintainer, as he wrote the original bindings.
> > Please scream if not appropriate.
>
> I'm not affiliated with TI in any way, so if someone from TI
> wants to take responsibility, that would probably be better.
>
> For for the time being...
>
> Acked-by: David Lechner <david@xxxxxxxxxxxxxx>

Thanks!

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/ti,bluetooth.yaml
> > @@ -0,0 +1,91 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/ti,bluetooth.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Texas Instruments Bluetooth Chips
> > +
> > +maintainers:
> > +  - David Lechner <david@xxxxxxxxxxxxxx>
> > +
> > +description: |
> > +  This documents the binding structure and common properties for serial
> > +  attached TI Bluetooth devices. The following chips are included in this
> > +  binding:
> > +
> > +  * TI CC256x Bluetooth devices
> > +  * TI WiLink 7/8 (wl12xx/wl18xx) Shared Transport BT/FM/GPS devices
> > +
> > +  TI WiLink devices have a UART interface for providing Bluetooth, FM radio,
> > +  and GPS over what's called "shared transport". The shared transport is
> > +  standard BT HCI protocol with additional channels for the other functions.
> > +
> > +  TI WiLink devices also have a separate WiFi interface as described in
> > +  wireless/ti,wlcore.yaml.
> > +
> > +  This bindings follows the UART slave device binding in ../serial/serial.yaml.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - ti,cc2560
> > +      - ti,wl1271-st
> > +      - ti,wl1273-st
> > +      - ti,wl1281-st
> > +      - ti,wl1283-st
> > +      - ti,wl1285-st
> > +      - ti,wl1801-st
> > +      - ti,wl1805-st
> > +      - ti,wl1807-st
> > +      - ti,wl1831-st
> > +      - ti,wl1835-st
> > +      - ti,wl1837-st
> > +
> > +  enable-gpios:
> > +    maxItems: 1
> > +
> > +  vio-supply:
> > +    description: Vio input supply (1.8V)
> > +
> > +  vbat-supply:
> > +    description: Vbat input supply (2.9-4.8V)
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    items:
> > +      - const: ext_clock
> > +
> > +  max-speed: true
>
> Does this mean that max-speed from serial.yaml is supported
> but current-speed is not?

I added it because one DTS uses "max-speed", and the driver
supports it.
The driver does not support "current-speed", but seems to ask for
an initial speed of 115200, and an operational speed of max-speed
(default 3000000, perhaps that should be documented in the bindings):

        hci_uart_set_speeds(hu, 115200, max_speed);

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux