On Tue, Oct 19, 2021 at 05:58:58PM +0800, Meng Li wrote: > From: Andrey Gusakov <andrey.gusakov@xxxxxxxxxxxxxxxxxx> > > Add PCIe regulators for KingFisher board. > > Signed-off-by: Meng Li <Meng.Li@xxxxxxxxxxxxx> > --- You've not provided a Signed-off-by for Andrey, please see Documentation/process/submitting-patches.rst for details on what this is and why it's important. > + host->pcie3v3 = devm_regulator_get_optional(dev, "pcie3v3"); > + host->pcie1v8 = devm_regulator_get_optional(dev, "pcie1v8"); Unless PCIe works without these supplies (which are in my understanding mandatory according to the spec) these should not be optional, this API is for supplies that may be physically absent.
Attachment:
signature.asc
Description: PGP signature
