Hi Marek, On Mon, Oct 18, 2021 at 09:47:13PM +0200, Marek Vasut wrote: > On 10/18/21 8:08 PM, Laurent Pinchart wrote: > > [...] > > >> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > >> index 1faae3e323a4..708de84ac138 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > >> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > >> @@ -79,6 +79,14 @@ properties: > >> - port@0 > >> - port@1 > >> > >> + pclk-sample: > >> + description: > >> + Data sampling on rising or falling edge. > >> + enum: > >> + - 0 # Falling edge > >> + - 1 # Rising edge > >> + default: 0 > >> + > > > > Shouldn't this be moved to the endpoint, the same way data-mapping is > > defined as an endpoint property ? > > The strapping is a chip property, not port property, so no. For this particular chip that's true. I'm still not convinced overall. For some cases it could be a per-port property, and moving it there for lvds-codec too could allow implementing helpers to parse DT properties, without much drawback for this particular use case as far as I can see. It's hard to predict the future with certainty of course, so I won't insist. -- Regards, Laurent Pinchart
