On Fri, Oct 15, 2021 at 7:11 PM Alvin Šipraga <alvin@xxxxxxx> wrote: > This patch adds a realtek-smi subdriver for the RTL8365MB-VC 4+1 port > 10/100/1000M switch controller. The driver has been developed based on a > GPL-licensed OS-agnostic Realtek vendor driver known as rtl8367c found > in the OpenWrt source tree. This version is really nice! > v2 -> v3: > - following the stats change, it became apparent that the rtl8366 > helper library is no longer that helpful; scrap it and implement > the ethtool ops specifically for this chip I wonder if I should just scrap it in general when I convert RTL8366RB over to use your new nice callbacks? Just push that part down into the driver for each chip. I vaguely remember the RTL8366S having the same counters though... (I think this is why it is in the shared library at all.) Yours, Linus Walleij
