Hi Geert, Thanks for the review. On Wed, 13 Oct 2021 at 22:23, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Chunyan. > > On Thu, Sep 23, 2021 at 8:42 AM Chunyan Zhang <zhang.lyra@xxxxxxxxx> wrote: > > From: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx> > > > > Add a new bindings to describe ums512 clock compatible strings. > > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml > > > + clock-names: > > + minItems: 1 > > + maxItems: 4 > > After applying this to my local tree, as it is a dependency for 2/4 in > for-mfd-next: > > Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml: > properties:clock-names: {'required': ['maxItems']} is not allowed for > {'minItems': 1, 'maxItems': 4, 'items': [{'const': 'ext-26m'}, > {'const': 'ext-32k'}, {'const': 'ext-4m'}, {'const': 'rco-100m'}]} > hint: "maxItems" is not needed with an "items" list > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > so please drop the maxItems 4. Ok, I will, but I don't have this compile error on my side, how do you get this error report? I use the command below: make -k dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml and, make -k dt_binding_check Thanks, Chunyan > > > > + items: > > + - const: ext-26m > > + - const: ext-32k > > + - const: ext-4m > > + - const: rco-100m > > + > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds