On Wed, Oct 13, 2021 at 5:05 PM Anatolij Gustschin <agust@xxxxxxx> wrote:
>
> Fix build warnings like:
> localbus:ranges: 'oneOf' conditional failed, one must be fixed
> ...
> Warning (unit_address_vs_reg): /localbus: node has a reg or ranges property, but no unit name
> Warning (simple_bus_reg): /localbus/flash@0,0: simple-bus unit address format error, expected "0"
>
> Signed-off-by: Anatolij Gustschin <agust@xxxxxxx>
> ---
> arch/powerpc/boot/dts/a3m071.dts | 12 +++++-----
> arch/powerpc/boot/dts/a4m072.dts | 20 ++++++++---------
> arch/powerpc/boot/dts/charon.dts | 14 ++++++------
> arch/powerpc/boot/dts/cm5200.dts | 7 ++++--
> arch/powerpc/boot/dts/digsy_mtc.dts | 16 ++++++++------
> arch/powerpc/boot/dts/lite5200.dts | 4 ++--
> arch/powerpc/boot/dts/lite5200b.dts | 6 +++--
> arch/powerpc/boot/dts/media5200.dts | 20 +++++++++--------
> arch/powerpc/boot/dts/motionpro.dts | 32 +++++++++++++++------------
> arch/powerpc/boot/dts/mpc5200b.dtsi | 2 +-
> arch/powerpc/boot/dts/mucmc52.dts | 34 +++++++++++++++--------------
> arch/powerpc/boot/dts/o2d.dts | 10 +++++----
> arch/powerpc/boot/dts/o2d.dtsi | 12 +++++-----
> arch/powerpc/boot/dts/o2d300.dts | 10 +++++----
> arch/powerpc/boot/dts/o2dnt2.dts | 10 +++++----
> arch/powerpc/boot/dts/o2i.dts | 4 ++--
> arch/powerpc/boot/dts/o2mnt.dts | 4 ++--
> arch/powerpc/boot/dts/o3dnt.dts | 10 +++++----
> arch/powerpc/boot/dts/pcm030.dts | 2 +-
> arch/powerpc/boot/dts/pcm032.dts | 26 ++++++++++++----------
> arch/powerpc/boot/dts/tqm5200.dts | 4 ++--
> arch/powerpc/boot/dts/uc101.dts | 14 +++++++-----
> 22 files changed, 151 insertions(+), 122 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/a3m071.dts b/arch/powerpc/boot/dts/a3m071.dts
> index 034cfd8aa95b..14e59aaa0ba7 100644
> --- a/arch/powerpc/boot/dts/a3m071.dts
> +++ b/arch/powerpc/boot/dts/a3m071.dts
> @@ -87,15 +87,15 @@
> };
> };
>
> - localbus {
> + localbus@80000000 {
That's not right, as 0x80000000 doesn't exist in 'reg' or 'ranges'.
Without 'reg', the correct unit-address is 'fc000000'. Perhaps there
should be a 'reg' entry though.
> compatible = "fsl,mpc5200b-lpb","simple-bus";
> #address-cells = <2>;
> #size-cells = <1>;
> - ranges = <0 0 0xfc000000 0x02000000
> - 3 0 0xe9000000 0x00080000
> - 5 0 0xe8000000 0x00010000>;
> + ranges = <0 0 0xfc000000 0x02000000>,
> + <3 0 0xe9000000 0x00080000>,
> + <5 0 0xe8000000 0x00010000>;
>
> - flash@0,0 {
> + flash@0 {
This change is debatable. Normally, if we have chipselects, then
that's a separate field and a comma is appropriate. However, h/w with
chip selects require setup and aren't a simple-bus. I guess the
bootloader does the setup, so kind of a gray area.
The warning for this is off by default, so I'd leave it alone.
Rob
