Re: [PATCH v3] dt-bindings: media: Convert OV5640 binding to a schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Oct 15, 2021 at 08:53:00AM -0500, Rob Herring wrote:
> On Fri, 15 Oct 2021 09:28:30 +0200, Maxime Ripard wrote:
> > The Omnivision OV5640 is supported by Linux thanks to its device tree
> > binding.
> > 
> > Now that we have the DT validation in place, let's convert the device
> > tree bindings for that driver over to a YAML schema.
> > 
> > Cc: linux-media@xxxxxxxxxxxxxxx
> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> > Cc: Steve Longerbeam <slongerbeam@xxxxxxxxx>
> > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
> > 
> > ---
> > 
> > Changes from v2:
> >   - Fix whitespace error
> >   - Changed schema referenced for the port validation
> > ---
> >  .../devicetree/bindings/media/i2c/ov5640.txt  |  92 -----------
> >  .../bindings/media/i2c/ovti,ov5640.yaml       | 154 ++++++++++++++++++
> >  2 files changed, 154 insertions(+), 92 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/ti,cal.example.dt.yaml: camera-sensor@3c: 'AVDD-supply' is a required property
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/ti,cal.example.dt.yaml: camera-sensor@3c: 'DVDD-supply' is a required property
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/ti,cal.example.dt.yaml: camera-sensor@3c: 'DOVDD-supply' is a required property
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/1541399
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.

This warning can be ignored, it's fixed already in
e978d5271f7138b6d7c1dd90fe1b5492bc594b8b, which is part of linux-next
already and has been merged by Rob.

Maxime

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux