Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
From: Mauri Sandberg <maukka@xxxxxxxxxxxx>
Date: Fri, 15 Oct 2021 15:56:23 +0300
Cc: Mauri Sandberg <sandberg@xxxxxxxxxxxxx>, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, "open list:GPIO SUBSYSTEM" <linux-gpio@xxxxxxxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, devicetree <devicetree@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Drew Fustini <drew@xxxxxxxxxxxxxxx>
In-reply-to: <CAHp75VcjGpveAHNAW7Xf7d_Zf6LGSSyD6+qBiF9xxvb+EKs3tg@mail.gmail.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0


On 21.6.2021 20.43, Andy Shevchenko wrote:

+       gc->of_node = np;


This should be guarded by CONFIG_OF_GPIO.

In the Kconfig I have a dependency to OF_GPIO. Is the guarding stillnecessary? Or should the guard be added and dependency removed? Or havethem both?

Follow-Ups:
- Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
  - From: Andy Shevchenko

References:
- [PATCH v5 0/2] gpio: add generic gpio cascade
  - From: Mauri Sandberg
- [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
  - From: Mauri Sandberg
- Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v4 0/8] Add support for DMA2D of STMicroelectronics STM32 Soc series
Next by Date: [PATCH v4 0/2] pinctrl: pinctrl-microchip-sgpio: Extend to call reset driver
Previous by thread: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
Next by thread: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade
Index(es):
- Date
- Thread

[Index of Archives] [Device Tree Compilter] [Device Tree Spec] [Linux Driver Backports] [Video for Linux] [Linux USB Devel] [Linux PCI Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86] [Yosemite Backpacking]