Hi On Thu, 2021-10-14 at 09:31 -0500, Rob Herring wrote: > On Thu, 14 Oct 2021 15:58:33 +0800, Sam Shih wrote: > > This updates bindings for MT7986 pinctrl driver. The > > difference of pinctrl between mt7986a and mt7986b is that pin-41 to > > pin-65 do not exist on mt7986b > > > > Signed-off-by: Sam Shih <sam.shih@xxxxxxxxxxxx> > > > > --- > > v7 : updated pinctcl node binding description, and separate pinctrl > > part into a single patch series > > > > Original thread: > > https://urldefense.com/v3/__https://lore.kernel.org/all/8348ed3e-c561-ad7e-fe9e-a31ed346d8d0@xxxxxxxxx/__;!!CTRNKA9wMg0ARbw!yJc1hf6XafeskaOgY8TmMDpGDHuIDhx6AGIpuOiJRl7jCVYcnPmr6I4XKz2iy6O4$ > > > > > > v6 : fixed yamllint warnings/errors v2 > > v5 : fixed yamllint warnings/errors v1 > > v4 : used yaml format instead of txt format document > > v3 : make mt7986 pinctrl bindings as a separate file > > v2 : deleted the redundant description of mt7986a/mt7986b > > --- > > .../pinctrl/mediatek,mt7986-pinctrl.yaml | 364 > > ++++++++++++++++++ > > 1 file changed, 364 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pinctrl/mediatek,mt7986- > > pinctrl.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/pinctrl/mediatek,mt7986- > pinctrl.example.dts:52.36-57.15: ERROR (duplicate_node_names): > /example-0/soc/pinctrl@1001f000/uart1-pins: Duplicate node name > ERROR: Input tree has errors, aborting (use -f to force output) > make[1]: *** [scripts/Makefile.lib:385: > Documentation/devicetree/bindings/pinctrl/mediatek,mt7986- > pinctrl.example.dt.yaml] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1441: dt_binding_check] Error 2 > Sorry, I took the wrong patch in my local environment for submmit This should be "uart2_pins: uart2-pins { ... " I will send next patch to fix this. + uart2_pins: uart1-pins { + mux { + function = "uart"; + groups = "uart2"; + }; + }; > doc reference errors (make refcheckdocs): > > See > https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/1540821__;!!CTRNKA9wMg0ARbw!yJc1hf6XafeskaOgY8TmMDpGDHuIDhx6AGIpuOiJRl7jCVYcnPmr6I4XK9R-t-CX$ > > > This check can fail if there are any dependencies. The base for a > patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up > to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Thanks, Sam >
