Hi Horatiu, On Thu, 2021-10-14 at 10:59 +0200, Horatiu Vultur wrote: > On lan966x platform when the switch gets reseted then also the sgpio > gets reseted. The fix for this is to extend also the sgpio driver to > call the reset driver which will be reseted only once by the first > driver that is probed. > > Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> > --- > drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c > index 072bccdea2a5..e8a91d0824cb 100644 > --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c > +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c > @@ -17,6 +17,7 @@ > #include <linux/pinctrl/pinmux.h> > #include <linux/platform_device.h> > #include <linux/property.h> > +#include <linux/reset.h> > > #include "core.h" > #include "pinconf.h" > @@ -803,6 +804,7 @@ static int microchip_sgpio_probe(struct platform_device *pdev) > int div_clock = 0, ret, port, i, nbanks; > struct device *dev = &pdev->dev; > struct fwnode_handle *fwnode; > + struct reset_control *reset; > struct sgpio_priv *priv; > struct clk *clk; > u32 val; > @@ -813,6 +815,10 @@ static int microchip_sgpio_probe(struct platform_device *pdev) > > priv->dev = dev; > > + reset = devm_reset_control_get_shared(&pdev->dev, "switch"); Please use devm_reset_control_get_optional_shared() for optional resets and handle errors. That will return NULL in case the optional reset is not specified in the device tree. It seems weird to me that the reset input to the GPIO controller is called "switch" reset. You can request a single unnamed reset with reset = devm_reset_control_get_shared(&pdev->dev, NULL); although that would limit future extendability in case this driver will ever require to handle multiple separate resets. If you decide to request the reset control by name, the yaml binding should specify the same name. > + if (!IS_ERR(reset)) > + reset_control_reset(reset); With optional resets, this can be just: reset_control_reset(reset); regards Philipp
