RE: [PATCH v2 2/2] arm64: dts: renesas: rzg2l-smarc-som: Enable Ethernet

[Biju Das <biju.das.jz@xxxxxxxxxxxxxx>]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v2 2/2] arm64: dts: renesas: rzg2l-smarc-som: Enable
> Ethernet
> 
> Hi Biju,
> 
> On Wed, Oct 13, 2021 at 9:57 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Enable Ethernet{0,1} interfaces on RZ/G2L SMARC EVK.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
> 
> > @@ -65,6 +74,58 @@
> >         /delete-node/ channel@7;
> >  };
> >
> > +&eth0 {
> > +       pinctrl-0 = <&eth0_pins>;
> > +       pinctrl-names = "default";
> > +       phy-handle = <&phy0>;
> > +       phy-mode = "rgmii-id";
> > +       status = "okay";
> > +
> > +       phy0: ethernet-phy@7 {
> > +               compatible = "ethernet-phy-id0022.1640",
> > +                            "ethernet-phy-ieee802.3-c22";
> > +               reg = <7>;
> 
> I guess you didn't wire up the PHY interrupt because the pinctrl driver
> doesn't support interrupts yet?

Yes, That is correct. We are lacking phy interrupt support. Once support is added in pinctrl driver, will add phy interrupt support.

> 
> And when the VersaClock5 clock generator is described, we need to add a
> clocks property.

Agreed. Will add this when we add VersaClock3 clock generator support in mainline.

Regards,
Biju

> 
> > +               rxc-skew-psec = <2400>;
> > +               txc-skew-psec = <2400>;
> > +               rxdv-skew-psec = <0>;
> > +               txdv-skew-psec = <0>;
> > +               rxd0-skew-psec = <0>;
> > +               rxd1-skew-psec = <0>;
> > +               rxd2-skew-psec = <0>;
> > +               rxd3-skew-psec = <0>;
> > +               txd0-skew-psec = <0>;
> > +               txd1-skew-psec = <0>;
> > +               txd2-skew-psec = <0>;
> > +               txd3-skew-psec = <0>;
> 
> Sigh. Who thought it was a good idea to use *-skew-psec for KSZ9131, and
> *-skew-ps for all other devices?
> 
> > +       };
> > +};
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue
> in renesas-devel for v5.16.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds