> -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Thursday, October 14, 2021 2:40 AM > To: Ming Qian <ming.qian@xxxxxxx> > Cc: shawnguo@xxxxxxxxxx; Aisheng Dong <aisheng.dong@xxxxxxx>; > s.hauer@xxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; festevam@xxxxxxxxx; > hverkuil-cisco@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; > mchehab@xxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: [EXT] Re: [PATCH v10 01/13] dt-bindings: media: amphion: add > amphion video codec bindings > > Caution: EXT Email > > On Wed, 13 Oct 2021 16:27:17 +0800, Ming Qian wrote: > > Add devicetree binding documentation for amphion Video Processing Unit > > IP presents on NXP i.MX8Q > > > > Signed-off-by: Ming Qian <ming.qian@xxxxxxx> > > Signed-off-by: Shijie Qin <shijie.qin@xxxxxxx> > > Signed-off-by: Zhou Peng <eagle.zhou@xxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > .../bindings/media/amphion,vpu.yaml | 178 > ++++++++++++++++++ > > 1 file changed, 178 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/amphion,vpu.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media > /amphion,vpu.yaml: > patternProperties:^vpu_core@[0-9a-f]+$:properties:compatible:oneOf: > [{'const': 'nxp,imx8q-vpu-decoder'}, {'const': 'nxp,imx8q-vpu-encoder'}] should > not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': > ['const']}} > hint: Use 'enum' rather than 'oneOf' + 'const' entries > from schema $id: > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr > ee.org%2Fmeta-schemas%2Fkeywords.yaml%23&data=04%7C01%7Cmin > g.qian%40nxp.com%7Ce295945bcfb243ca9b6d08d98e78da87%7C686ea1d3b > c2b4c6fa92cd99c5c301635%7C0%7C0%7C637697471988904558%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJXVCI6Mn0%3D%7C1000&sdata=fOAy2B6rSge9vUFFMXg1CWuDD > UVqapcDxEMH0DOIcbI%3D&reserved=0 > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media > /amphion,vpu.yaml: properties:compatible:oneOf: [{'const': > 'nxp,imx8qm-vpu'}, {'const': 'nxp,imx8qxp-vpu'}] should not be valid under > {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}} > hint: Use 'enum' rather than 'oneOf' + 'const' entries > from schema $id: > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetr > ee.org%2Fmeta-schemas%2Fkeywords.yaml%23&data=04%7C01%7Cmin > g.qian%40nxp.com%7Ce295945bcfb243ca9b6d08d98e78da87%7C686ea1d3b > c2b4c6fa92cd99c5c301635%7C0%7C0%7C637697471988904558%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJXVCI6Mn0%3D%7C1000&sdata=fOAy2B6rSge9vUFFMXg1CWuDD > UVqapcDxEMH0DOIcbI%3D&reserved=0 > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media > /amphion,vpu.yaml: ignoring, error in schema: patternProperties: > ^vpu_core@[0-9a-f]+$: properties: compatible: oneOf > warning: no schema found in > file: ./Documentation/devicetree/bindings/media/amphion,vpu.yaml > Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0: > /example-0/vpu@2c000000: failed to match any schema with compatible: > ['nxp,imx8qm-vpu'] > Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0: > /example-0/vpu@2c000000/vpu_core@2d080000: failed to match any > schema with compatible: ['nxp,imx8q-vpu-decoder'] > Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0: > /example-0/vpu@2c000000/vpu_core@2d090000: failed to match any > schema with compatible: ['nxp,imx8q-vpu-encoder'] > Documentation/devicetree/bindings/media/amphion,vpu.example.dt.yaml:0:0: > /example-0/vpu@2c000000/vpu_core@2d0a0000: failed to match any > schema with compatible: ['nxp,imx8q-vpu-encoder'] > > doc reference errors (make refcheckdocs): > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw > ork.ozlabs.org%2Fpatch%2F1540273&data=04%7C01%7Cming.qian%40n > xp.com%7Ce295945bcfb243ca9b6d08d98e78da87%7C686ea1d3bc2b4c6fa92 > cd99c5c301635%7C0%7C0%7C637697471988904558%7CUnknown%7CTWF > pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC > I6Mn0%3D%7C1000&sdata=VZB1wJBe3b4WMHdhPVqlqZDoNRcui2mk0 > VYAN4NbXDU%3D&reserved=0 > > This check can fail if there are any dependencies. The base for a patch series is > generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. I meet the error after upgrade dtschema, I'll fix it and submit again
