Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

url:    https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: i386-randconfig-m031-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

smatch warnings:
drivers/hwmon/tmp421.c:178 tmp421_enable_channels() error: uninitialized symbol 'err'.

vim +/err +178 drivers/hwmon/tmp421.c

4a0f8262fe071b Krzysztof Adamski 2021-10-12  168  static int tmp421_enable_channels(struct tmp421_data *data)
4a0f8262fe071b Krzysztof Adamski 2021-10-12  169  {
4a0f8262fe071b Krzysztof Adamski 2021-10-12  170  	int err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12  171  	struct i2c_client *client = data->client;
4a0f8262fe071b Krzysztof Adamski 2021-10-12  172  	struct device *dev = &client->dev;
4a0f8262fe071b Krzysztof Adamski 2021-10-12  173  	int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
4a0f8262fe071b Krzysztof Adamski 2021-10-12  174  	int i;
4a0f8262fe071b Krzysztof Adamski 2021-10-12  175  
4a0f8262fe071b Krzysztof Adamski 2021-10-12  176  	if (cfg < 0) {
4a0f8262fe071b Krzysztof Adamski 2021-10-12  177  		dev_err(dev, "error reading register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12 @178  		return err;

"return cfg;"

4a0f8262fe071b Krzysztof Adamski 2021-10-12  179  	}
4a0f8262fe071b Krzysztof Adamski 2021-10-12  180  
4a0f8262fe071b Krzysztof Adamski 2021-10-12  181  	cfg &= ~TMP421_CONFIG_REG_REN_MASK;
4a0f8262fe071b Krzysztof Adamski 2021-10-12  182  	for (i = 0; i < data->channels; i++)
4a0f8262fe071b Krzysztof Adamski 2021-10-12  183  		if (data->channel[i].enabled)
4a0f8262fe071b Krzysztof Adamski 2021-10-12  184  			cfg |= TMP421_CONFIG_REG_REN(i);
4a0f8262fe071b Krzysztof Adamski 2021-10-12  185  
4a0f8262fe071b Krzysztof Adamski 2021-10-12  186  	err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
4a0f8262fe071b Krzysztof Adamski 2021-10-12  187  	if (err < 0)
4a0f8262fe071b Krzysztof Adamski 2021-10-12  188  		dev_err(dev, "error writing register, can't disable channels\n");
4a0f8262fe071b Krzysztof Adamski 2021-10-12  189  
4a0f8262fe071b Krzysztof Adamski 2021-10-12  190  	return err;
4a0f8262fe071b Krzysztof Adamski 2021-10-12  191  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux