On Wed, 6 Oct 2021 at 12:45, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>
> Prior to this patch was teedev_close_context() calling tee_device_put()
> before teedev_ctx_put() leading to teedev_ctx_release() accessing
> ctx->teedev just after the reference counter was decreased on the
> teedev. Fix this by calling teedev_ctx_put() before tee_device_put().
>
> Fixes: 217e0250cccb ("tee: use reference counting for tee_context")
> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
> ---
> drivers/tee/tee_core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Sumit Garg <sumit.garg@xxxxxxxxxx>
-Sumit
> diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c
> index 2b37bc408fc3..85102d12d716 100644
> --- a/drivers/tee/tee_core.c
> +++ b/drivers/tee/tee_core.c
> @@ -98,8 +98,10 @@ void teedev_ctx_put(struct tee_context *ctx)
>
> static void teedev_close_context(struct tee_context *ctx)
> {
> - tee_device_put(ctx->teedev);
> + struct tee_device *teedev = ctx->teedev;
> +
> teedev_ctx_put(ctx);
> + tee_device_put(teedev);
> }
>
> static int tee_open(struct inode *inode, struct file *filp)
> --
> 2.31.1
>
