Re: (subset) [PATCH v3 2/3] arm64: dts: exynos: add initial support for exynosautov9 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/10/2021 19:17, Krzysztof Kozlowski wrote:
> On Sun, 10 Oct 2021 12:22:45 +0900, Chanho Park wrote:
>> Add minimal support for ExynosAuto v9 SoC[1].
>>
>> - Enumarate all pinctrl nodes
>> - UART with exynos850 compatible
>> - UFS0 HCI + Phy
>>
>> Like exynos850, this also uses fixed-rate clock nodes until clock driver
>> has been supported. The clock nodes are initialized on bootloader stage
>> thus we don't need to control them so far.
>>
>> [...]
> 
> Applied, thanks!
> 
> [2/3] arm64: dts: exynos: add initial support for exynosautov9 SoC
>       commit: f695b3f4c45d0051416fa7315cf553bec70198d8

... and dropped as build system found dtc W=1 warnings:

../arch/arm64/boot/dts/exynos/exynosautov9.dtsi:78.20-83.5: Warning
(unit_address_format): /cpus/cpu@000000: unit name should not have
leading 0s
../arch/arm64/boot/dts/exynos/exynosautov9.dtsi:85.20-90.5: Warning
(unit_address_format): /cpus/cpu@000100: unit name should not have
leading 0s
../arch/arm64/boot/dts/exynos/exynosautov9.dtsi:92.20-97.5: Warning
(unit_address_format): /cpus/cpu@000200: unit name should not have
leading 0s
../arch/arm64/boot/dts/exynos/exynosautov9.dtsi:99.20-104.5: Warning
(unit_address_format): /cpus/cpu@000300: unit name should not have
leading 0s
../arch/arm64/boot/dts/exynos/exynosautov9.dtsi:187.38-198.5: Warning
(simple_bus_reg): /soc@0/interrupt-controller@11001000: simple-bus unit
address format error, expected "10101000"
../arch/arm64/boot/dts/exynos/exynosautov9.dtsi:255.28-264.5: Warning
(simple_bus_reg): /soc@0/uart@103000000: simple-bus unit address format
error, expected "10300000"

Please fix them plus these fixes:


--- a/arch/arm64/boot/dts/exynos/exynosautov9-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9-pinctrl.dtsi
@@ -570,14 +570,14 @@ hsi2c1_bus: hsi2c1-bus-pins {
        };

        /* PERIC0 USI01 */
-       hsi2c2_bus_pins: hsi2c2-bus-pins {
+       hsi2c2_bus: hsi2c2-bus-pins {
                samsung,pins = "gpp0-4", "gpp0-5";
                samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
        };

        /* PERIC0 USI01_I2C */
-       hsi2c3_bus_pins: hsi2c3-bus-pins {
+       hsi2c3_bus: hsi2c3-bus-pins {
                samsung,pins = "gpp0-6", "gpp0-7";
                samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
@@ -1066,7 +1066,7 @@ spi9_cs_func: spi9-cs-func-pins {
        };

        /* PERIC1 USI10_SPI */
-       spi10_pins: spi10-pins {
+       spi10_bus: spi10-bus-pins {
                samsung,pins = "gpp5-2", "gpp5-1", "gpp5-0";
                samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
@@ -1088,7 +1088,7 @@ spi10_cs_func: spi10-cs-func-pins {
        };

        /* PERIC1 USI11_SPI */
-       spi11_pins: spi11-pins {
+       spi11_bus: spi11-bus-pins {
                samsung,pins = "gpp3-6", "gpp3-5", "gpp3-4";
                samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
                samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index d884ae421e12..1dd1d73a52b8 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -171,7 +171,7 @@ uart_clock: uart-clock {
                 * Keep the stub clock for ufs driver, until proper clock
                 * driver is implemented.
                 */
-               ufs_core_clock: uart-core-clock {
+               ufs_core_clock: ufs-core-clock {


Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux