On Sun, Oct 10, 2021 at 01:15:53PM +0200, Ansuel Smith wrote: > Document new binding qca,power_on_sel used to enable Power-on-strapping > select reg and qca,led_open_drain to set led to open drain mode. Please spend 5 minutes to proof-read your emails before sending. You will find tons of spelling mistakes and inconsistencies. The commit message refers to qca,led_open_drain and qca,power_on_sel which are not the names added to the documentation. > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index 05a8ddfb5483..71cd45818430 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -13,6 +13,17 @@ Required properties: > Optional properties: > > - reset-gpios: GPIO to be used to reset the whole device > +- qca,ignore-power-on-sel: Ignore power on pin strapping to configure led open > + drain or eeprom presence. This is needed for broken > + device that have wrong configuration or when the oem _devices_ that _have_ > + decided to not use pin strapping and fallback to sw > + regs. > +- qca,led-open-drain: Set leds to open-drain mode. This require the This _requires_ > + qca,ignore-power-on-sel to be set or the driver will fail > + to probe. This is needed if the oem doesn't use pin oem _prefers_ > + strapping to set this mode and prefer to set it using sw > + regs. The pin strapping related to led open drain mode is > + the pin B68 for QCA832x and B49 for QCA833x > > Subnodes: > > -- > 2.32.0 >
