On Sat, Oct 09, 2021 at 07:24:45PM +0200, Andrew Lunn wrote: > On Fri, Oct 08, 2021 at 02:22:25AM +0200, Ansuel Smith wrote: > > QCA8328 is the birrget brother of 8327. Document the new compatible > > birrget? > > > Me sending patch lat at night... it was brother. > > binding. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > index 9fb4db65907e..0e84500b8db2 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > @@ -3,6 +3,7 @@ > > Required properties: > > > > - compatible: should be one of: > > + "qca,qca8328" > > "qca,qca8327" > > "qca,qca8334" > > "qca,qca8337" > > This is much nice than the old DT property. But since the internal IDs > are the same, i think it would be good to add a little documentation > here about how the 8327 and 8328 differ, since most people are not > going to look at the commit message. > > Andrew Ok will add some description on how to understand the correct compatible to use. -- Ansuel
