On Sat, Oct 09, 2021 at 05:18:55PM +0200, Andrew Lunn wrote: > On Fri, Oct 08, 2021 at 02:22:16AM +0200, Ansuel Smith wrote: > > Document new qca,rgmii0_1_8v and qca,rgmii56_1_8v needed to setup > > mac_pwr_sel register for qca8337 switch. Specific the use of this binding > > that is used only in qca8337 and not in qca8327. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > index 8c73f67c43ca..9383d6bf2426 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > @@ -13,6 +13,14 @@ Required properties: > > Optional properties: > > > > - reset-gpios: GPIO to be used to reset the whole device > > +- qca,rgmii0-1-8v: Set the internal regulator to supply 1.8v for MAC0 port. > > + This is needed for qca8337 and toggles the supply voltage > > + from 1.5v to 1.8v. For the specific regs it was observed > > + that this is needed only for ipq8064 and ipq8065 target. > > +- qca,rgmii56-1-8v: Set the internal regulator to supply 1.8v for MAC5/6 port. > > + This is needed for qca8337 and toggles the supply voltage > > + from 1.5v to 1.8v. For the specific regs it was observed > > + that this is needed only for ipq8065 target. > > Are ipq8065 & ipq8064 SoCs which the switch is embedded into? So you > could look for the top level compatible and set these regulators based > on that. No DT property needed. > > Andrew The switch is still external for these 2 SoC. If we really want, yes we can follow that route and sets only for the 2 SoC. (Considering ipq8065 is still not present, can I add it anyway in the qca8k code? Will for sure propose the ipq8065 dtsi today) -- Ansuel
