Hi
On Thu, Sep 30, 2021 at 9:22 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> On Wed, Sep 29, 2021 at 5:35 PM Philip Chen <philipchen@xxxxxxxxxxxx> wrote:
> >
> > Factor out ti-sn65dsi86 edp bridge as a separate dts fragment.
> > This helps us introduce the second source edp bridge later.
> >
> > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > Signed-off-by: Philip Chen <philipchen@xxxxxxxxxxxx>
> > ---
> >
> > Changes in v2:
> > - Move edp_brij_i2c completely out of sc7180-trogdor.dtsi to the
> > bridge dts fragment, so that we can cleanly assign different
> > edp bridge in every board rev.
> >
> > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 +
> > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 1 +
> > .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 1 +
> > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 1 +
> > .../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 90 +++++++++++++++++++
> > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 86 ------------------
> > 6 files changed, 94 insertions(+), 86 deletions(-)
> > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > index a758e4d22612..1d13fba3bd2f 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > @@ -11,6 +11,7 @@
> > ap_h1_spi: &spi0 {};
> >
> > #include "sc7180-trogdor.dtsi"
> > +#include "sc7180-trogdor-ti-sn65dsi86.dtsi"
>
> It looks like you're missing homestar, aren't you? I'd expect that
> after applying your change that:
>
> git grep -A1 include.*sc7180-trogdor.dtsi
>
> ...should show your new include right after all includes of
> sc7180-trogdor.dtsi, but I don't see it for homestar.
I can't find homestar dts file in my upstream checkout.
But I found: https://patchwork.kernel.org/project/linux-arm-msm/patch/20210909122053.1.Ieafda79b74f74a2b15ed86e181c06a3060706ec5@changeid/
...Is it merged anywhere?
>
> Other than that this looks good to me. Feel free to add my Reviewed-by.
