Re: [PATCH 3/3] arm64: dts: exynos: add minimal support for exynosautov9 sadk board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/10/2021 14:08, Chanho Park wrote:
> SADK(Samsung Automotive Development Kit) is the development kit to
> evaluate Exynos Auto v9 SoC. It has 16GB LPDDR4 DRAM and two
> 256GB Samsung UFS. This patch enables only serial console and ufs0
> device.
> 
> Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx>
> ---
>  .../bindings/arm/samsung/samsung-boards.yaml  |  6 +++
>  .../boot/dts/exynos/exynosautov9-sadk.dts     | 52 +++++++++++++++++++

You need also Makefile entry.

>  2 files changed, 58 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> index 0796f0c87727..2147e664d5bc 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
> @@ -199,6 +199,12 @@ properties:
>                - samsung,exynos7-espresso        # Samsung Exynos7 Espresso
>            - const: samsung,exynos7
>  
> +      - description: Exynos Auto v9 based boards
> +        items:
> +          - enum:
> +              - samsung,samsung,exynosautov9-sadk   # Samsung Exynos Auto v9 SADK

Double samsung.

> +          - const: samsung,exynosautov9
> +
>  required:
>    - compatible
>  
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> new file mode 100644
> index 000000000000..e59ef39a368f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Samsung ExynosAutov9 SADK board device tree source

Any Copyrights? Not needed, just mentioning...

> + */
> +
> +/dts-v1/;
> +#include "exynosautov9.dtsi"

Include gpio.h here, because it is used. Probably you can also remove it
from dtsi - I did not see it being used in there.

> +
> +/ {
> +	model = "Samsung ExynosAutov9 SADK board";
> +	compatible = "samsung,exynosautov9-sadk", "samsung,exynosautov9";
> +
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &serial_0;
> +	};
> +
> +	chosen {
> +		stdout-path = &serial_0;
> +	};
> +
> +	memory@80000000 {
> +		device_type = "memory";
> +		reg = <0x0 0x80000000 0x0 0x77000000>,
> +		      <0x8 0x80000000 0x1 0x7ba00000>,
> +		      <0xa 0x00000000 0x2 0x00000000>;
> +	};
> +
> +	ufs_0_fixed_vcc: fixedregulator@0 {

Node name: "regulator" or "regulator-0" if you think you will have more
of them.

> +		compatible = "regulator-fixed";
> +		regulator-name = "ufs-vcc";
> +		gpio = <&gpq0 1 GPIO_ACTIVE_HIGH>;
> +		regulator-boot-on;
> +		enable-active-high;
> +	};
> +};
> +
> +&serial_0 {
> +	status = "okay";
> +};
> +
> +&ufs_0_phy {
> +	status = "okay";
> +};
> +
> +&ufs_0 {
> +	status = "okay";
> +	vcc-supply = <&ufs_0_fixed_vcc>;
> +	vcc-fixed-regulator;
> +};
> 


Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux