On Thu, Oct 07, 2021 at 02:09:36AM +0200, Andrew Lunn wrote: > On Thu, Oct 07, 2021 at 12:35:56AM +0200, Ansuel Smith wrote: > > Document new qca,rgmii0_1_8v and qca,rgmii56_1_8v needed to setup > > mac_pwr_sel register for ar8327 switch. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > index 8c73f67c43ca..1f6b7d2f609e 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > > @@ -13,6 +13,8 @@ Required properties: > > Optional properties: > > > > - reset-gpios: GPIO to be used to reset the whole device > > +- qca,rgmii0-1-8v: Set the internal regulator to supply 1.8v for MAC0 port > > +- qca,rgmii56-1-8v: Set the internal regulator to supply 1.8v for MAC5/6 port > > What is the consumer of these 1.8v? The MACs are normally internal, > the regulators are internal, so why is a DT property needed? > > Andrew Only some device require this, with these bit at 0, the internal regulator provide 1.5v. It's not really a on/off but a toggle of the different operating voltage. Some device require this and some doesn't. -- Ansuel
