On Tue, Oct 5, 2021 at 11:29 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 5 Oct 2021 11:15:48 -0500 Rob Herring wrote:
> > On Tue, Oct 5, 2021 at 10:53 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> > > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> > > of VLANs...") introduced a rbtree for faster Ethernet address look
> > > up. To maintain netdev->dev_addr in this tree we need to make all
> > > the writes to it got through appropriate helpers.
> > >
> > > There are roughly 40 places where netdev->dev_addr is passed
> > > as the destination to a of_get_mac_address() call. Add a helper
> > > which takes a dev pointer instead, so it can call an appropriate
> > > helper.
> > >
> > > Note that of_get_mac_address() already assumes the address is
> > > 6 bytes long (ETH_ALEN) so use eth_hw_addr_set().
> > >
> > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> > > ---
> > > drivers/of/of_net.c | 25 +++++++++++++++++++++++++
> >
> > Can we move this file to drivers/net/ given it's always merged via the
> > net tree? It's also the only thing left not part of the driver
> > subsystems.
>
> Hm, our driver core historically lives under net/core, not drivers/net,
> how about drivers/of/of_net.c -> net/core/of_net.c ?
Sure.
Rob
