Hi Randy, On 04/10/21 17:28, Randy Dunlap wrote: > On 10/4/21 6:07 AM, Luca Ceresoli wrote: >> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig >> index ad93b3550d6d..622d690c883a 100644 >> --- a/drivers/power/supply/Kconfig >> +++ b/drivers/power/supply/Kconfig >> @@ -557,6 +557,17 @@ config CHARGER_MAX77693 >> help >> Say Y to enable support for the Maxim MAX77693 battery charger. >> +config CHARGER_MAX77976 >> + tristate "Maxim MAX77976 battery charger driver" >> + depends on REGMAP_I2C >> + help >> + The Maxim MAX77976 is a 19 Vin, 5.5A 1-Cell Li+ Battery Charger >> + USB OTG support. It has an I2C interface for configuration. >> + >> + Say Y to enable support for the Maxim MAX77976 battery charger. >> + This driver can also be built as a module. If so, the module >> will be >> + called max77976_charger. > > REGMAP_I2C is not a user-settable config option, so drivers should not > "depend on" it. This should be more like: > > depends on I2C > select REGMAP_I2C Ouch, thanks for spotting, will fix in v2. -- Luca