Re: [PATCH 1/3] dt-bindings: mtd: spi-nor: add n25q00 schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/23/21 9:59 PM, Pratyush Yadav wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> +Tudor
> 
> On 20/09/21 02:41PM, Paweł Anikiel wrote:
>> Add schema for the n25q00 NOR flash memory.
>>
>> Signed-off-by: Paweł Anikiel <pan@xxxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index ed590d7c6e37..efb3c5e05c5a 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -18,7 +18,7 @@ properties:
>>        - items:
>>            - pattern: "^((((micron|spansion|st),)?\
>>                (m25p(40|80|16|32|64|128)|\
>> -              n25q(32b|064|128a11|128a13|256a|512a|164k)))|\
>> +              n25q(00|32b|064|128a11|128a13|256a|512a|164k)))|\
> 
> IIUC this is supposed to only be for legacy/old flashes that started out
> using flash-specific compatibles. Any new flashes should simply use
> jedec,spi-nor unless there is a legitimate reason to do so.

that's correct, the generic compatible should suffice for these flashes.

> 
> Until you justify that reason,
> 
> Nacked-by: Pratyush Yadav <p.yadav@xxxxxx>

I agree.

Cheers,
ta




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux