Re: [PATCH 1/5] dt-bindings: sdhci-omap: Update binding for legacy SoCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 5, 2021 at 3:04 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>
> Hi,
>
> * Adam Ford <aford173@xxxxxxxxx> [211002 13:29]:
> > I noticed that you added omap3 compatibility to the driver and the
> > bindings, but no device tree changes for omap3.dtsi to enable this.
> > Is there anything holding back?
>
> There is at least the wl1251 quirk handling missing as I mentioned in
> the cover letter. I guess we could enable sdhci except for wl1251 users
> though.

Sorry, I guess I missed the cover letter.  I didn't see any obvious
differences between the drivers other than the hsmmc driver enumerated
before the DMA, so it threw some splat indicating that.  The newer
driver appears to enumerate after the DMA, so that message
disappeared.

>
> > I modified omap3.dtsi and changed the compatible flag to
> > ti,omap3-sdhci and it boots from SD card just fine.  For some reason,
> > I cannot get the wl1283 to function, but the driver probes, so I need
> > to spend some time investigating this.
> >
> > If i can get my wl1283 working again, I'll reply with a tested note.
> > I hope to have more time tomorrow, but i can't do it any more today.
>
> I don't have wl1283 omap3 devices online, but I have tested that the
> sdhci patches do work with wl12xx and mwifiex drivers. Did you figure
> out why your wl1283 is not working with sdhci?

I did get it working.  It was a MAC address issue.  I didn't properly
set the MAC address.  Once I did, it worked just fine.

I think I sent a 2nd reply with a tested-by message.

adam
>
> Regards,
>
> Tony



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux