On 04-10-21, 11:01, Shawn Guo wrote: > Hi Vinod, > > On Fri, Oct 01, 2021 at 01:46:23PM +0530, Vinod Koul wrote: > > Hi Shawn, > > > > On 28-09-21, 10:19, Shawn Guo wrote: > > > The series adds missing vdd-supply for QUSB2 PHY which is required for > > > digital circuit. The driver works right now likely because firmware > > > already sets it up. Add it to bindings, driver and DTS that miss the > > > supply. > > > > > > It should not cause problem for existing DTBs: > > > - SC7180, SDM630, SDM845 based platforms already specified vdd-supply > > > in the DTBs. > > > - MSM8996 and MSM8998 platform DTBs miss vdd-supply, but dummy regulator > > > will ensure QUSB2 PHY driver works as before on these platforms. > > > > What about the rest.. I checked SM8350 and SM8250 mtp ones are missing > > this. With the property made mandatory, I guess it would cause these to > > fail right.. > > >From what I can see, SM8350 and SM8250 use qcom-snps-femto-v2 PHY > rather than qcom-qusb2. So they should not be affected by this series. Right, somehow I seem to have overlooked that part :( I am applying this now, thanks -- ~Vinod
