On Tue, Oct 05, 2021 at 03:03:40AM +0300, Laurent Pinchart wrote: > Hi Marek, > > Thank you for the patch. > > On Tue, Jul 27, 2021 at 06:13:56PM +0200, Marek Vasut wrote: > > Decoder input LVDS format is a property of the decoder chip or even > > its strapping. Add DT property data-mapping the same way lvds-panel > > does, to define the LVDS data mapping. > > > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx > > To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> I think I have to retract this, see below :-( > And all my apologies for the delay. > > > --- > > V2: - Use allOf > > - Move the data-mapping to endpoint > > V3: - Rebase on V2 submitted a while ago, reinstate changelog > > - Drop the allOf and un-rebase on previous pclk patch > > V4: - port@1, remove $ref: /schemas/graph.yaml#/properties/port and > > add $ref: /schemas/graph.yaml#/$defs/port-base > > --- > > .../bindings/display/bridge/lvds-codec.yaml | 33 ++++++++++++++++++- > > 1 file changed, 32 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > index 304a1367faaa7..c0400c60f272a 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > @@ -55,11 +55,26 @@ properties: > > For LVDS decoders, port 0 is the LVDS input > > > > port@1: > > - $ref: /schemas/graph.yaml#/properties/port > > + $ref: /schemas/graph.yaml#/$defs/port-base > > description: | > > For LVDS encoders, port 1 is the LVDS output > > For LVDS decoders, port 1 is the parallel output > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-mapping: > > + enum: > > + - jeida-18 > > + - jeida-24 > > + - vesa-24 > > + description: | > > + The color signals mapping order. See details in > > + Documentation/devicetree/bindings/display/panel/lvds.yaml > > + Shouldn't this be for port 0 ? For decoders, port 1 is the parallel side, not the LVDS side. With this fixed, you can retain the Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > required: > > - port@0 > > - port@1 > > @@ -71,6 +86,22 @@ properties: > > > > power-supply: true > > > > +if: > > + not: > > + properties: > > + compatible: > > + contains: > > + const: lvds-decoder > > +then: > > + properties: > > + ports: > > + properties: > > + port@1: > > + properties: > > + endpoint: > > + properties: > > + data-mapping: false > > + > > required: > > - compatible > > - ports -- Regards, Laurent Pinchart
