Hi Aparna,
On 04/10/21 4:57 pm, Aparna M wrote:
> * Convert gpio-tpic2810 bindings to yaml format
> * Remove outdated gpio-tpic2810 bindings in .txt format
>
Usually, I have not seen the commit messages being listed as points, but
rather written as paragraph.
Also, I see the following warnings on running dt_binding_check,
./Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml:10:4:
[warning] wrong indentation: expected 2 but found 3 (indentation)
./Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml:27:5:
[warning] wrong indentation: expected 2 but found 4 (indentation)
Thanks,
Aswath
> Signed-off-by: Aparna M <a-m1@xxxxxx>
> ---
> .../bindings/gpio/gpio-tpic2810.txt | 16 -------
> .../bindings/gpio/gpio-tpic2810.yaml | 48 +++++++++++++++++++
> 2 files changed, 48 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
> deleted file mode 100644
> index 1afc2de7a537..000000000000
> --- a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -TPIC2810 GPIO controller bindings
> -
> -Required properties:
> - - compatible : Should be "ti,tpic2810".
> - - reg : The I2C address of the device
> - - gpio-controller : Marks the device node as a GPIO controller.
> - - #gpio-cells : Should be two. For consumer use see gpio.txt.
> -
> -Example:
> -
> - gpio@60 {
> - compatible = "ti,tpic2810";
> - reg = <0x60>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
> new file mode 100644
> index 000000000000..6d4e22143551
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/gpio-tpic2810.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TPIC2810 GPIO controller bindings
> +
> +maintainers:
> + - Aswath Govindraju <a-govindraju@xxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tpic2810
> +
> + reg:
> + maxItems: 1
> + description: The I2C address of the device
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - "#gpio-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio@60 {
> + compatible = "ti,tpic2810";
> + reg = <0x60>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> + };
>
