On 2014-08-08 at 09:09:19 +0200, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote: > > On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo <gyungoh@xxxxxxxxx> wrote: > [...] > > > +#ifdef CONFIG_OF > > > +static const struct of_device_id sky81452_of_match[] = { > > > + {.compatible = "sky,sky81452",}, > > > + { } > > > +}; > > > +MODULE_DEVICE_TABLE(of, sky81452_of_match); > > > +#endif > > > > The #ifdefery here is not needed since you use of_match_ptr below, whcih > > will expand to NULL of CONFIG_OF is not set. > > On the contrary, that's exactly why the #ifdef is needed here. If you > don't guard the OF match table here, then of_match_ptr() evaluating to > NULL will cause the table to become unused and the compiler warning > about it. Oops, yes of course. Sorry about that and thanks for your correction. Tobias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html