On 9/28/21 7:28 AM, Rob Herring wrote: > On Tue, 28 Sep 2021 03:03:28 -0500, Samuel Holland wrote: >> These new RTC variants all have a single alarm, like the R40 variant. >> >> For the new SoCs, start requiring a complete list of input clocks. The >> H616 has three required clocks. The R329 also has three required clocks >> (but one is different), plus an optional crystal oscillator input. The >> D1 RTC is identical to the one in the R329. >> >> And since these new SoCs will have a well-defined output clock order as >> well, they do not need the clock-output-names property. >> >> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx> >> --- >> Changes since v1: >> - Properly update the DT binding clocks and clock-names properties. >> >> .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 72 ++++++++++++++++++- >> include/dt-bindings/clock/sun6i-rtc.h | 10 +++ >> 2 files changed, 79 insertions(+), 3 deletions(-) >> create mode 100644 include/dt-bindings/clock/sun6i-rtc.h >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml:122:9: [error] duplication of key "minItems" in mapping (key-duplicates) > ./Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml:150:9: [error] duplication of key "minItems" in mapping (key-duplicates) Whoops, I have a couple of minItems where I meant maxItems. Sorry, will fix for v3. Samuel
