> + * Some baudrates are not supported by the chip, so we use the next > + * lower rate supported and update termios c_flag. I don't see the termios updating being done now ? > + data->clk = of_clk_get(np, 0); > + if (IS_ERR(data->clk)) { > + pr_warn("Can't get timer clock"); > + return PTR_ERR(data->clk); > + } > + > + err = clk_prepare_enable(data->clk); > + if (err) { > + pr_warn("Can't prepare clock"); and these do need a newline on them. They are also not very useful as they don't indicate what device was involved. If you passed pdev from mtk8250_probe you'd be able to use dev_warn instead Otherwise looks great and exactly as 8250_core is intended to be used. Alan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html