Quoting Philip Chen (2021-09-24 16:54:13) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi > new file mode 100644 > index 000000000000..7b1034a5a8e9 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi > @@ -0,0 +1,87 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Trogdor dts fragment for the boards with TI sn65dsi86 edp bridge > + * > + * Copyright 2021 Google LLC. > + */ > + > +&dsi0_out { > + remote-endpoint = <&sn65dsi86_in>; > + data-lanes = <0 1 2 3>; > +}; > + > +&edp_brij_i2c { > + sn65dsi86_bridge: bridge@2d { > + compatible = "ti,sn65dsi86"; > + reg = <0x2d>; > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_brij_en>, <&edp_brij_irq>; Why not move edp_brij_en as well? I think you want to reuse the node name for the other bridge, but it doesn't make sense unless that other patch is part of this series. > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-parent = <&tlmm>; > + interrupts = <11 IRQ_TYPE_LEVEL_HIGH>; > + > + enable-gpios = <&tlmm 104 GPIO_ACTIVE_HIGH>;