On Fri, Sep 24, 2021 at 04:42:21PM -0500, Rob Herring wrote:
> Commit 078fb7aa6a83 ("arm: dts: vexpress: Fix addressing issues with
> 'motherboard-bus' nodes") broke booting on a couple of 32-bit VExpress
> boards. The problem is #address-cells size changed, but interrupt-map
> was not updated. This results in the timer interrupt (and all the
> other motherboard interrupts) not getting mapped.
>
> As the 'interrupt-map' properties are all just duplicates across boards,
> just move them into vexpress-v2m.dtsi and vexpress-v2m-rs1.dtsi.
> Strictly speaking, 'interrupt-map' is dependent on the parent
> interrupt controller, but it's not likely we'll ever have a different
> parent than GICv2 on these old platforms. If there was one,
> 'interrupt-map' can still be overridden.
>
> Fixes: 078fb7aa6a83 ("arm: dts: vexpress: Fix addressing issues with 'motherboard-bus' nodes")
> Reported-by: Reported-by: "kernelci.org bot" <bot@xxxxxxxxxxxx>
> Cc: Guillaume Tucker <guillaume.tucker@xxxxxxxxxxxxx>
> Cc: Liviu Dudau <liviu.dudau@xxxxxxx>
> Cc: Sudeep Holla <sudeep.holla@xxxxxxx>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> I tested this on QEMU VExpress CA9. I also added a check to dtc for
> 'interrupt-map' to catch this kind of error. I need to run it on the
> rest of the tree and upstream it before enabling in the kernel.
>
Thanks for fixing this quickly. This time I tested on both Juno and TC2.
Sorry I missed to test it on TC2 earlier as the board was not accessible.
--
Regards,
Sudeep
