Hi, I accidentally send this to the device-tree list instead of to the bluetooth list. So I'm going to resend this now to the right list. Note the second copy you will receive is unchanged, I'm just fixing the Cc. Regards, Hans On 9/24/21 11:41 AM, Hans de Goede wrote: > Since the hci_uart_register_device() call is the last thing we do in > h5_serdev_probe() we can simply directly return its return-value. > > Cc: Archie Pusaka <apusaka@xxxxxxxxxx> > Suggested-by: Archie Pusaka <apusaka@xxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > drivers/bluetooth/hci_h5.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c > index 59b712742d33..3e067c7cabff 100644 > --- a/drivers/bluetooth/hci_h5.c > +++ b/drivers/bluetooth/hci_h5.c > @@ -814,7 +814,6 @@ static int h5_serdev_probe(struct serdev_device *serdev) > struct device *dev = &serdev->dev; > struct h5 *h5; > const struct h5_device_data *data; > - int err; > > h5 = devm_kzalloc(dev, sizeof(*h5), GFP_KERNEL); > if (!h5) > @@ -858,11 +857,7 @@ static int h5_serdev_probe(struct serdev_device *serdev) > if (IS_ERR(h5->device_wake_gpio)) > return PTR_ERR(h5->device_wake_gpio); > > - err = hci_uart_register_device(&h5->serdev_hu, &h5p); > - if (err) > - return err; > - > - return 0; > + return hci_uart_register_device(&h5->serdev_hu, &h5p); > } > > static void h5_serdev_remove(struct serdev_device *serdev) >
