Hi,
On Thu, 23 Sep 2021 08:26:58 +0200
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> On Wed, 22 Sept 2021 at 22:38, Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > On Wed, 22 Sep 2021 09:41:39 +0200
> > Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >
> > [...]
> > > > + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
> > >
> > > Thanks for the patch.
> > >
> > > This does not look like passing the schema validation. Please run
> > > dtbs_check. The node names should use hyphens and end with "grp"
> > > suffix. This remark applies to other cases below.
> > >
> > dtbs_check reports a lot of errors originating from imx6sll.dtsi and
> > friends. But nothing added by me. But yes, node names should use
> > hyphens, that is documented. I will fix that.
> >
> > But having -grp at the end for these things with a frequency in the
> > name is uncommon.
> > $ grep -R :.*100mhz arch/arm/boot/dts/imx6s*.dts
> > arch/arm/boot/dts/imx6sl-evk.dts: pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
> > arch/arm/boot/dts/imx6sl-evk.dts: pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
> > arch/arm/boot/dts/imx6sl-evk.dts: pinctrl_usdhc3_100mhz: usdhc3grp100mhz {
> > arch/arm/boot/dts/imx6sll-evk.dts: pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
> > arch/arm/boot/dts/imx6sll-evk.dts: pinctrl_usdhc3_100mhz: usdhc3grp_100mhz {
> > arch/arm/boot/dts/imx6sll-kobo-clarahd.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz {
> > arch/arm/boot/dts/imx6sll-kobo-clarahd.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {
> > arch/arm/boot/dts/imx6sll-kobo-librah2o.dts: pinctrl_usdhc1_100mhz: usdhc1grp-100mhz {
> > arch/arm/boot/dts/imx6sll-kobo-librah2o.dts: pinctrl_usdhc3_100mhz: usdhc3grp_100mhz {
> > arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz {
> > arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {
> > arch/arm/boot/dts/imx6sl-tolino-shine3.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz {
> > arch/arm/boot/dts/imx6sl-tolino-shine3.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {
> > arch/arm/boot/dts/imx6sl-tolino-vision5.dts: pinctrl_usdhc1_100mhz: usdhc1grp-100mhz {
> > arch/arm/boot/dts/imx6sl-tolino-vision5.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {
> > arch/arm/boot/dts/imx6sl-warp.dts: pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
> > arch/arm/boot/dts/imx6sl-warp.dts: pinctrl_usdhc3_100mhz: usdhc3grp100mhz {
> > arch/arm/boot/dts/imx6sx-nitrogen6sx.dts: pinctrl_usdhc4_100mhz: usdhc4-100mhzgrp {
> > arch/arm/boot/dts/imx6sx-sabreauto.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz {
> > arch/arm/boot/dts/imx6sx-softing-vining-2000.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz {
> > arch/arm/boot/dts/imx6sx-softing-vining-2000.dts: pinctrl_usdhc4_100mhz: usdhc4-100mhz {
>
> I was fixing primarily arm64 boards and did not touch that many of armv7:
> grep -R :.*100mhz.*grp arch/arm64/boot/dts/freescale/* | wc -l
> 46
>
I will send a v2 with the 100mhz style used there. I will not clean up
dtbs_check issues originating from imx6sl[l].dtsi in this series. That
would be an issue for a separate series.
Regards,
Andreas
