Hi Lee,
lee.jones@xxxxxxxxxx wrote on Wed, 22 Sep 2021 16:57:10 +0100:
> On Wed, 15 Sep 2021, Miquel Raynal wrote:
>
> > There was in the past a typo in the coordinate readouts property. The
> > bindings have been updated, the touchscreen driver as well and now
> > supports both. However, the MFD driver that is in charge of verifying
> > the validity of the property only checks the bogus one. Add support for
> > the correctly spelled DT property.
> >
> > Fixes: c9aeb249bf72 ("Input: ti_am335x_tsc - fix spelling mistake in TSC/ADC DT binding")
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > ---
> > drivers/mfd/ti_am335x_tscadc.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> > index 155a8ed879b3..aa46ed669016 100644
> > --- a/drivers/mfd/ti_am335x_tscadc.c
> > +++ b/drivers/mfd/ti_am335x_tscadc.c
> > @@ -144,8 +144,14 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> > if (tscadc->data->has_tsc) {
> > node = of_get_child_by_name(pdev->dev.of_node, "tsc");
> > of_property_read_u32(node, "ti,wires", &tscmag_wires);
> > - of_property_read_u32(node, "ti,coordiante-readouts", &readouts);
> > + err = of_property_read_u32(node, "ti,coordinate-readouts",
> > + &readouts);
> > + if (err < 0)
> > + of_property_read_u32(node, "ti,coordiante-readouts",
> > + &readouts);
> > +
>
> How long are you proposing that we support this churn?
Well, I am not proposing anything, I am just "fixing" the driver so
that it fits the bindings :) Given the fact that at the end of this
series there is a patch that changes the "coordiante" typo to
"coordinate" in a device tree source file, I believe it is still too
soon...
Thanks,
Miquèl
