> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Thursday, September 23, 2021 3:26 AM > To: Richard Zhu <hongxing.zhu@xxxxxxx> > Cc: l.stach@xxxxxxxxxxxxxx; kishon@xxxxxx; vkoul@xxxxxxxxxx; > galak@xxxxxxxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx; > linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for the > pad modes of imx8 pcie phy > > On Fri, Sep 17, 2021 at 10:31:00AM +0800, Richard Zhu wrote: > > Add binding for reference clock PAD modes of the i.MX8 PCIe PHY. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> > > --- > > include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h > > > > diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h > b/include/dt-bindings/phy/phy-imx8-pcie.h > > new file mode 100644 > > index 000000000000..fe198a0cc12c > > --- /dev/null > > +++ b/include/dt-bindings/phy/phy-imx8-pcie.h > > @@ -0,0 +1,14 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > Perhaps this should match the dts files license... > Hi Rob: What's the means of the "dts files license"? I'm not clear understand that. I found that there are almost similar "/* SPDX-License-Identifier: GPL-2.0 */" license contained in the files of the /include/dt-bindings/phy folder. Best Regards Richard Zhu > > +/* > > + * This header provides constants for i.MX8 PCIe. > > + */ > > + > > +#ifndef _DT_BINDINGS_IMX8_PCIE_H > > +#define _DT_BINDINGS_IMX8_PCIE_H > > + > > +/* Reference clock PAD mode */ > > +#define IMX8_PCIE_REFCLK_PAD_NO_USED 0 > > +#define IMX8_PCIE_REFCLK_PAD_INPUT 1 > > +#define IMX8_PCIE_REFCLK_PAD_OUTPUT 2 > > + > > +#endif /* _DT_BINDINGS_IMX8_PCIE_H */ > > -- > > 2.25.1 > > > >
