Quoting Stephan Gerhold (2021-09-21 08:21:19) > Using underscores in device tree nodes is not very common. > Additionally, the _region suffix in "smem_region@..." is not really > useful since it's obvious that it describes a reserved memory region. > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 5551dba2d5fd..95dea20cde75 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > @@ -41,7 +41,7 @@ tz-apps@86000000 { > no-map; > }; > > - smem_mem: smem_region@86300000 { > + smem_mem: smem@86300000 { Shouldn't that be smem_mem: memory@86300000? Node names should be generic. > reg = <0x0 0x86300000 0x0 0x100000>; > no-map; > };