Re: [RFC PATCH net-next 12/12] net: lan966x: add ethtool configuration and statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH net-next 12/12] net: lan966x: add ethtool configuration and statistics
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Mon, 20 Sep 2021 13:31:26 -0700
Cc: <davem@xxxxxxxxxxxxx>, <robh+dt@xxxxxxxxxx>, <andrew@xxxxxxx>, <linux@xxxxxxxxxxxxxxx>, <f.fainelli@xxxxxxxxx>, <alexandre.belloni@xxxxxxxxxxx>, <vladimir.oltean@xxxxxxx>, <UNGLinuxDriver@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-phy@xxxxxxxxxxxxxxxxxxx>, <linux-pm@xxxxxxxxxxxxxxx>
In-reply-to: <20210920095218.1108151-13-horatiu.vultur@microchip.com>

On Mon, 20 Sep 2021 11:52:18 +0200 Horatiu Vultur wrote:
> +static void lan966x_get_eth_mac_stats(struct net_device *dev,
> +				      struct ethtool_eth_mac_stats *mac_stats)

Great to see this API used, please also consider adding RMON stats
since the seem to be present.

References:
- [RFC PATCH net-next 00/12] Add lan966x driver
  - From: Horatiu Vultur
- [RFC PATCH net-next 12/12] net: lan966x: add ethtool configuration and statistics
  - From: Horatiu Vultur

Prev by Date: Re: [PATCH v6 1/3] dt-bindings: Add YAML bindings for NVDEC
Next by Date: [PATCH] ARM: dts: at91: tse850: the emac<->phy interface is rmii
Previous by thread: [RFC PATCH net-next 12/12] net: lan966x: add ethtool configuration and statistics
Next by thread: [RFC PATCH net-next 11/12] net: lan966x: add mactable support
Index(es):
- Date
- Thread

[Index of Archives] [Device Tree Compilter] [Device Tree Spec] [Linux Driver Backports] [Video for Linux] [Linux USB Devel] [Linux PCI Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86] [Yosemite Backpacking]

Powered by Linux