Re: [PATCH v3 7/9] dt-bindings: arm: fsl: clean-up all toradex boards/modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 20, 2021 at 9:19 AM Marcel Ziswiler
<marcel.ziswiler@xxxxxxxxxxx> wrote:
>
> Hi Rob
>
> On Mon, 2021-09-20 at 07:28 -0500, Rob Herring wrote:
> > On Sun, 19 Sep 2021 14:55:34 +0200, Marcel Ziswiler wrote:
> > > From: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> > >
> > > Simplify and unify the distinction between modules and carrier boards.
> > >
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> > > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > > Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
> > >
> > > ---
> > >
> > > Changes in v3:
> > > - Add Fabio's reviewed-by. Thanks!
> > > - Add Rob's ack. Thanks!
> > >
> > > Changes in v2:
> > > - New patch cleaning-up dt-bindings documentation.
> > >
> > >  .../devicetree/bindings/arm/fsl.yaml          | 79 ++++++++++---------
> > >  1 file changed, 41 insertions(+), 38 deletions(-)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/arm/fsl.yaml:475:111: [warning] line too long (113 > 110 characters)
> > (line-length)
> > ./Documentation/devicetree/bindings/arm/fsl.yaml:612:111: [warning] line too long (113 > 110 characters)
> > (line-length)
> >
> > dtschema/dtc warnings/errors:
> >
> > doc reference errors (make refcheckdocs):
> >
> > See https://patchwork.ozlabs.org/patch/1529833
> >
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
>
> Strange, I have done all of that but I still can not convince dt_binding_check on my system to show me that
> same yamllint warnings/errors on that fsl.yaml file. However, it otherwise seems to work as it shows dozens of
> other issues throughout Documentation/devicetree/bindings but those are not for me to fix, at least not right
> now (;-p).

You shouldn't be seeing dozens of warnings unless you are on the
current linux-next. linux-next shouldn't be the basis for your
development as that's not a tree any maintainer applies patches to.

Rob



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux