On 20/09/21 06:06PM, Serge Semin wrote:
> Hello Apurva
>
> On Mon, Sep 20, 2021 at 07:57:12PM +0530, Apurva Nandan wrote:
> > Convert spi-nand.txt binding to YAML format with an added example.
> >
> > Signed-off-by: Apurva Nandan <a-nandan@xxxxxx>
> > ---
> > .../devicetree/bindings/mtd/spi-nand.txt | 5 --
> > .../devicetree/bindings/mtd/spi-nand.yaml | 62 +++++++++++++++++++
> > 2 files changed, 62 insertions(+), 5 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
> > create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.yaml
[...]
>
> > + spi-max-frequency: true
> > + spi-rx-bus-width: true
> > + spi-tx-bus-width: true
> > + rx-sample-delay-ns: true
>
> Since it's an SPI-client device there are more than these properties
> could be set for it. See the SPI-controller bindings schema:
> Documentation/devicetree/bindings/spi/spi-controller.yaml
> So there is two possible ways to make it more generic:
> 1) Detach the spi-client part from the spi-controller.yaml bindings
> into a dedicated DT-schema file and refer to that new scheme from
> here.
> 2) Forget about these controller-specific properties and let the
> parental SPI-controller bindings parsing them. Of course there must be
> at least one of the next properties declared for it to work:
> {unevaluatedProperties, additionalProperties}.
I proposed a patch series [0] to fix this for SPI NOR, which can be used
here as well. A re-roll is long overdue though. Let me see when I can
find time to get to it. In the meantime, this should be fine IMO.
[0] https://patchwork.kernel.org/project/spi-devel-general/list/?series=497129&state=%2A&archive=both
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
