Hi, On 19/09/2021 23:31, Anand Moon wrote: > As described in the Odroid-n2 & Odroid-n2-plus schematics, > the 5V regulator is controlled by GPIOH_8 and in Open Drain > since this GPIO doesn't support Push-Pull. > Fixes: c35f6dc5c377 ("arm64: dts: meson: Add minimal support for Odroid-N2") Fixes: ef599f5f3e10 ("arm64: dts: meson: convert ODROID-N2 to dtsi") > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > index 4f33820aba1f..e8a00a2f8812 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > @@ -99,6 +99,8 @@ vcc_5v: regulator-vcc_5v { > regulator-max-microvolt = <5000000>; > regulator-always-on; > vin-supply = <&main_12v>; > + gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>; > + enable-active-high; > }; > > vcc_1v8: regulator-vcc_1v8 { > Exact I wonder how I missed this.... Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> Thanks, Neil