> +#define APPLE_ASC_MBOX_CONTROL_FULL BIT(16) > +#define APPLE_ASC_MBOX_CONTROL_EMPTY BIT(17) ... > +#define APPLE_M3_MBOX_CONTROL_FULL BIT(16) > +#define APPLE_M3_MBOX_CONTROL_EMPTY BIT(17) It might make sense to combine these to just > +#define APPLE_MBOX_CONTROL_FULL BIT(16) > +#define APPLE_MBOX_CONTROL_EMPTY BIT(17) ..unless we have a reason to think the status bits otherwise differ. Regardless of that minor nit, this is Reviewed-by: Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx>