On Mon, 13 Sep 2021 19:55:53 +0100, Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx> wrote: > > > +config PCIE_APPLE_MSI_DOORBELL_ADDR > > + hex > > + default 0xfffff000 > > + depends on PCIE_APPLE > > + > > config PCIE_APPLE > > tristate "Apple PCIe controller" > > depends on ARCH_APPLE || COMPILE_TEST > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > > index 1ed7b90f8360..76344223245d 100644 > > --- a/drivers/pci/controller/pcie-apple.c > > +++ b/drivers/pci/controller/pcie-apple.c > > @@ -120,8 +120,10 @@ > > * The doorbell address is set to 0xfffff000, which by convention > > * matches what MacOS does, and it is possible to use any other > > * address (in the bottom 4GB, as the base register is only 32bit). > > + * However, it has to be excluded from the the IOVA range, and the > > + * DART driver has to know about it. > > */ > > -#define DOORBELL_ADDR 0xfffff000 > > +#define DOORBELL_ADDR CONFIG_PCIE_APPLE_MSI_DOORBELL_ADDR > > I'm unsure if Kconfig is the right place for this. But if it is, these > hunks should be moved earlier in the series (so the deletion gets > squashed away of the hardcoded-in-the-C.) I'd rather not doing that. There is a progression in the series, and moving the value over to Kconfig is part of that progression. Thanks, M. -- Without deviation from the norm, progress is not possible.
