Quoting Srinivasa Rao Mandadapu (2021-09-15 04:15:43) > > On 9/14/2021 1:21 AM, Stephen Boyd wrote: > > Quoting Srinivasa Rao Mandadapu (2021-09-13 06:17:41) > >> diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > >> new file mode 100644 > >> index 0000000..e0d705f > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml > >> +patternProperties: > >> + "^dai-link@[0-9a-f]$": > >> + description: > >> + Each subnode represents a dai link. Subnodes of each dai links would be > >> + cpu/codec dais. > >> + > >> + type: object > >> + > >> + properties: > >> + link-name: > >> + description: Indicates dai-link name and PCM stream name. > >> + $ref: /schemas/types.yaml#/definitions/string > >> + maxItems: 1 > >> + > >> + reg: > >> + maxItems: 1 > >> + description: dai link address. > >> + > >> + cpu: > >> + description: Holds subnode which indicates cpu dai. > >> + type: object > >> + properties: > >> + sound-dai: true > > Shouldn't sound-dai be required? > Sorry. I didn't get your Query. You mean in below "required:" properties > need to add sound-dai also? I'd expect there to be a required: list for the 'cpu' and 'codec' objects that says sound-dai, unless that is implicit somehow. I'm definitely not an expert in the DT yaml, but I suspect two more 'required:' sections are needed so that 'sound-dai' isn't an optional property.
