Hi, On Sun, Sep 5, 2021 at 11:42 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > > +++ b/drivers/gpu/drm/panel/panel-simple-edp.c > > @@ -0,0 +1,1298 @@ > > +/* > > + * Copyright (C) 2013, NVIDIA Corporation. All rights reserved. > > + * > > + * Permission is hereby granted, free of charge, to any person obtaining a > > + * copy of this software and associated documentation files (the "Software"), > > + * to deal in the Software without restriction, including without limitation > > + * the rights to use, copy, modify, merge, publish, distribute, sub license, > > + * and/or sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice (including the > > + * next paragraph) shall be included in all copies or substantial portions > > + * of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL > > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > > + * DEALINGS IN THE SOFTWARE. > > + */ > Would be nice if you could use the SPDX thingy for the license. I'm going to leave this alone. I definitely started this driver by copy-pasting the panel-simple.c file and it still shares a lot of lines of code with that driver. It feels like that qualifies for the "substantial portions of the Software" portion which tells me to retain the license. I also kept Thierry as the author since, again, it's really a splitting of the existing driver and not the creation of a new driver. In fact, if I were to assign a new author/license to panel-edp, one could also make the argument that I should assign a new author/license to panel-simple. panel-simple got ~50% of the old panels and panel-edp got the other ~50% of the old panels plus a search-and-replace of "simple" for "edp" and some code deletion. I don't think search-and-replace name change nor code deletion is justification for claiming authorship. ;-) If Thierry wants to chime in and say that I should put down a different license for either of the two files, though, I'd be glad to change it. -Doug
