Re: [PATCH 4/8] hwmon: (tmp421) add support for defining labels from DT

[Krzysztof Adamski <krzysztof.adamski@xxxxxxxxx>]

Dnia Tue, Sep 07, 2021 at 08:46:22AM -0700, Guenter Roeck napisał(a):
> > +void tmp421_probe_child_from_dt(struct i2c_client *client,
> > +				struct device_node *child,
> > +				struct tmp421_data *data)
> > +
> > +{
> > +	struct device *dev = &client->dev;
> > +	u32 i;
> > +	int err;
> > +
> > +	err = of_property_read_u32(child, "reg", &i);
> > +	if (err) {
> > +		dev_err(dev, "missing reg property of %pOFn\n", child);
> > +		return;
>
> Report to caller

My idea was to make those errors in DT non-critical. I.e. if one of the
child nodes is not well structured, I just skip it but continue the
probing. Do you think it should be considered critical and I should
abort the whole probe function as soon as I detect such DT errors,
instead?

Krzysztof