On 17:27-20210907, Jan Kiszka wrote:
> On 07.09.21 17:16, Nishanth Menon wrote:
> > On 16:22-20210907, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> >>
> >> Product Generations 1 and 2 differ in the SOC revision which requires
> >> separate device trees.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> >> ---
> >> arch/arm64/boot/dts/ti/Makefile | 2 +
> >> .../dts/ti/k3-am65-iot2050-common-pg1.dtsi | 46 ++++++++++++++++
> >> .../dts/ti/k3-am65-iot2050-common-pg2.dtsi | 51 ++++++++++++++++++
> >> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 35 +-----------
> >> ...ts => k3-am6528-iot2050-basic-common.dtsi} | 12 ++---
> >> .../dts/ti/k3-am6528-iot2050-basic-pg2.dts | 21 ++++++++
> >> .../boot/dts/ti/k3-am6528-iot2050-basic.dts | 53 ++-----------------
> >> ...=> k3-am6548-iot2050-advanced-common.dtsi} | 8 +--
> >> .../dts/ti/k3-am6548-iot2050-advanced-pg2.dts | 26 +++++++++
> >> .../dts/ti/k3-am6548-iot2050-advanced.dts | 52 ++----------------
> >> 10 files changed, 161 insertions(+), 145 deletions(-)
> >> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg1.dtsi
> >> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg2.dtsi
> >> copy arch/arm64/boot/dts/ti/{k3-am6528-iot2050-basic.dts => k3-am6528-iot2050-basic-common.dtsi} (80%)
> >> create mode 100644 arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dts
> >> copy arch/arm64/boot/dts/ti/{k3-am6548-iot2050-advanced.dts => k3-am6548-iot2050-advanced-common.dtsi} (86%)
> >> create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dts
> >
> >
> > Few things:
> >
> > a) Could you split this patch so that the refactoring for SR1 is the
> > first patch and then introduce the SR2?
>
> Can do, sure
>
> > b) Please call these as sr (silicon revision) rather than pg.
>
> Nope, this is only motivated by the SR1->SR2 switch. The new products
> are called "PG2", and that is what the DT name must reflect. Took me a
> while to grasp that as well.
Aaah.. thanks.. will be good to document the same. I think you did mean
Product Generation as PG.. please call it out explicitly in the commit
message.
>
> > c) usual request: Please add urls for the board
>
> Where should they go? I think there is only one reasonable to share:
>
> https://new.siemens.com/global/en/products/automation/pc-based/iot-gateways/simatic-iot2050.html
>
> If that is a stable link, I can't tell.
Please confirm and add that to the commit message of the patch that introduces pg2 board.
I'd also suggest adding the link to the dts file.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
