On Mon, 6 Sep 2021 21:53:18 +0800 chaochao2021666@xxxxxxx wrote: > From: chao zeng <chao.zeng@xxxxxxxxxxx> > > This commit extend panic trigger, add two new panic trigger > "panic_on" and "panic_off" and keep the "panic" compatible with > "panic_blink". > > All the led on the "panic_on" would light and on > the "panic_off" would turn off We don't wont gazillion triggers, each for every possible setting. Instead extend the existing panic trigger to have another sysfs setting where you can set this behavior. echo panic >trigger echo blink >on_panic So the on_panic file can accept "on", "off" or "blink". Alternatively a pattern could be set as in the ledtrig-pattern trigger. Also your patches do not use correct spacing in commit titles: leds:triggers:Extend the kernel panic LED trigger should instead be leds: triggers: Extend the kernel panic LED trigger Marek